-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better readme to Helm chart #4366
Better readme to Helm chart #4366
Conversation
@kbegiedza , thanks for your contribution! @azhavoro , could you please look? |
@kbegiedza Hello, what issue does the init container you added in this patch solve? |
@azhavoro Thanks for question. Without it, I had to manually exec |
The back-end container startup process invokes the migration on every run, including the first https://github.com/openvinotoolkit/cvat/blob/develop/supervisord.conf#L62 and I don't see the command is overridden in the deployment https://github.com/openvinotoolkit/cvat/blob/develop/helm-chart/templates/cvat_backend/deployment.yml#L44-L117 and it seems that this init container looks unnecessary. Your changes to README.md look ok, but I think it's better to understand why the migration is not run on first deployment in your case. |
Thanks for review @azhavoro, will remove init container from PR and investigate it further (and open new one if needed). |
@azhavoro fix'd |
Sorry for the late response, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kbegiedza , thanks for your contribution!
Co-authored-by: Andrey Zhavoronkov <[email protected]>
Motivation and context
Trying to install and configure with helm was very painful, this PR tries to cover few things:
How has this been tested?
Dry-run helm and released to brand new cluster.
Checked https certificates and frontend / backend connection.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.