Fixed bug: Error in Create project from backup for Standard 3D Annotation #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Jan 14, 2022
cvat/apps/engine/task.py
Outdated
| for idx in range(len(media_files)): | ||
| properties = manifest[manifest_index(idx)] | ||
|
|
||
| # FIXME it's bad solution because a manifest file can contain more files then were uploaded |
There was a problem hiding this comment.
@Marishka17 , what are we going to do with the comment?
nmanovic
reviewed
Jan 14, 2022
| raise ValueError('Incorrect width field') | ||
| if not isinstance(_dict['height'], int): | ||
| raise ValueError('Incorrect height field') | ||
| # FIXME |
There was a problem hiding this comment.
@Marishka17 , the same question. What are we going to do with the comment? It looks like we disable two checks which can be important for 2D case.
There was a problem hiding this comment.
@nmanovic, yes, but these checks are only relevant for the first element of the manifest file, and the reliability will drop a bit...
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolve #4105
How has this been tested?
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.