Cypress. New organization pipeline. #4143

dvkruchinin · 2022-01-11T10:22:10Z

Motivation and context

Adding a test to test the basic capabilities of the new functionality.
The test system has been improved in the form of adding css classes.
Added Cypress commands. Solved eslint errors in some files.

How has this been tested?

Checklist

I submit my changes into the develop branch
I have added a description of my changes into CHANGELOG file
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues (read github docs)
I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

organizations

…o dkru/cypress-case-113-new-organization-pipeline

.../integration/actions_projects_models_organizations/case_57_project_label_deleting_feature.js

tests/cypress.json

tests/cypress/support/commands.js

tests/cypress/integration/remove_users_tasks_projects_organizations.js

...ns_projects_models_organizations/registration_involved/case_113_new_organization_pipeline.js

bsekachev · 2022-01-19T21:11:02Z

tests/cypress/integration/actions_organizations/case_113_new_organization_pipeline.js

+            cy.logout();
+            cy.login(secondUserName, secondUser.password);
+            cy.checkOrganizationExists(organizationParams.shortName);
+            cy.contains('.cvat-item-task-name', taskName).should('exist');
+            cy.goToProjectsList();
+            cy.get('.cvat-empty-projects-list').should('exist');


A comment about this case:
Need to activate organization first. The second user cannot see the task if do not switch organization context (now the user sees the task, but it is a bug, will be fixed soon). The second user also sees the project (when organization is activated) on projects page (this is one more bug, will be fixed)

Fix for the second bug here: #4201

I merged last changed from develop with fix #4201. The second bug is not preproducing. I also thought it would be good to separate some tests and add additional steps. Please take a look.
I have commented out the checks that are not working now.

bsekachev · 2022-01-19T21:15:38Z

Generally everything fine, just please fix the latest comment and let's wait for bugfixes, than I will merge this patch.

…o dkru/cypress-case-113-new-organization-pipeline

bsekachev · 2022-01-24T08:15:17Z

tests/cypress/support/commands.js

+    cy.contains('.cvat-text-color', oldName).clear().type(`${newName}{Enter}`);
+    cy.contains('.cvat-task-details-task-name', newName).should('exist');
+});
+


Hi, @dvkruchinin

Text for ellipses has been added here #4229

Hi @bsekachev,

Great!
I`ll update the cypress command implemented in #4215

bsekachev · 2022-01-24T12:28:27Z

@dvkruchinin

Could you please merge develop and uncomment corresponding tests?

…o dkru/cypress-case-113-new-organization-pipeline

dvkruchinin · 2022-01-24T14:07:33Z

@dvkruchinin

Could you please merge develop and uncomment corresponding tests?

@bsekachev
Sure. Done.
But I also had to finalize some tests.
The user to whom the job is assigned can no longer open a job via a direct link without activating the organization.
The user excluded from the organization now does not see the task, even if it is assigned to him.

bsekachev · 2022-01-24T14:25:59Z

@dvkruchinin

The user to whom the job is assigned can no longer open a job via a direct link without activating the organization.
The user excluded from the organization now does not see the task, even if it is assigned to him.

This is expected.

dvkruchinin added 29 commits December 28, 2021 13:01

The folder renamed

b47fdb2

Add classes

42a861a

Rename the folder

8afe4af

Rename/rework the script for remoing users, tasts, projects,

a737196

organizations

Added commands for organizations

fee2f2a

Fix eslint issues

461673a

Fix workflow

05bb1f7

Move the test to the registration_involved folder

63ab57e

Added class

afc8f4c

Update the test. Added some commands.

d9e0367

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

77985d6

…o dkru/cypress-case-113-new-organization-pipeline

Added class

3da686d

Add a command. Updated the test.

4bc1315

Fix eslint issue

6cb168a

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

f633fcd

…o dkru/cypress-case-113-new-organization-pipeline

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

ce729ea

…o dkru/cypress-case-113-new-organization-pipeline

Added some classes

ccb40e2

Added cypress command. Update corespinding test.

6f931dc

Continue writin the test. Update commands.

5ae98f5

Continue writing the test

c0b4967

Update main.yml

a09a750

Add className

8c607a8

Update the test. Add command

98dc15e

Update the test

9b21875

Added command for remove a tasks, users, progects, orgs

a9eb74e

Some reworks

646a3cb

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

30a8f52

…o dkru/cypress-case-113-new-organization-pipeline

Add a class

709ddfc

Update the test

09c48d1

dvkruchinin requested a review from azhavoro as a code owner January 11, 2022 10:22

dvkruchinin added 2 commits January 13, 2022 11:28

Update year

2abb6f4

Update years

64e4bcd

bsekachev self-assigned this Jan 13, 2022

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

0dda630

…o dkru/cypress-case-113-new-organization-pipeline

dvkruchinin changed the title ~~Cypress. New organization pipeline.~~ [WIP] Cypress. New organization pipeline. Jan 17, 2022

dvkruchinin added 3 commits January 17, 2022 17:07

Update the stept in the test

434a3f5

Rework command to remove users, etc.

7650b1c

The tests adaptation

0c08d8e

dvkruchinin changed the title ~~[WIP] Cypress. New organization pipeline.~~ Cypress. New organization pipeline. Jan 17, 2022

bsekachev reviewed Jan 18, 2022

View reviewed changes

dvkruchinin added 4 commits January 19, 2022 10:30

Rework command to deleting users, etc.

3c0f3c8

Apply comments

9aaebe2

Revert changes except base_actions_project test

0e5726b

Rename the command to delete a task by api

4e8af63

bsekachev reviewed Jan 19, 2022

View reviewed changes

dvkruchinin added 6 commits January 20, 2022 10:23

Apply commenst. Split tests

9991014

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

e3adaea

…o dkru/cypress-case-113-new-organization-pipeline

Update the command, the test.

2822d04

Added steps to check

981c6b9

Fix support/index.js

0e31e14

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

d57b3dc

…o dkru/cypress-case-113-new-organization-pipeline

bsekachev reviewed Jan 24, 2022

View reviewed changes

dvkruchinin added 3 commits January 24, 2022 16:17

Merge branch 'develop' of https://github.com/openvinotoolkit/cvat int…

ab0e848

…o dkru/cypress-case-113-new-organization-pipeline

The test adaptation.

de7dfa1

Removed comments.

ea397bd

bsekachev merged commit e212d57 into cvat-ai:develop Jan 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cypress. New organization pipeline. #4143

Cypress. New organization pipeline. #4143

dvkruchinin commented Jan 11, 2022

bsekachev Jan 19, 2022

bsekachev Jan 19, 2022 •

edited

Loading

dvkruchinin Jan 20, 2022

bsekachev commented Jan 19, 2022

bsekachev Jan 24, 2022

dvkruchinin Jan 24, 2022

bsekachev commented Jan 24, 2022

dvkruchinin commented Jan 24, 2022

bsekachev commented Jan 24, 2022

Cypress. New organization pipeline. #4143

Cypress. New organization pipeline. #4143

Conversation

dvkruchinin commented Jan 11, 2022

Motivation and context

How has this been tested?

Checklist

License

bsekachev Jan 19, 2022

Choose a reason for hiding this comment

bsekachev Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

dvkruchinin Jan 20, 2022

Choose a reason for hiding this comment

bsekachev commented Jan 19, 2022

bsekachev Jan 24, 2022

Choose a reason for hiding this comment

dvkruchinin Jan 24, 2022

Choose a reason for hiding this comment

bsekachev commented Jan 24, 2022

dvkruchinin commented Jan 24, 2022

bsekachev commented Jan 24, 2022

bsekachev Jan 19, 2022 •

edited

Loading