Fix task data upload progress bar #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
previously approved these changes
Jan 10, 2022
cvat-ui/src/actions/tasks-actions.ts
Outdated
| @@ -414,7 +414,7 @@ export function createTaskAsync(data: any): ThunkAction<Promise<void>, {}, {}, A | |||
| dispatch(createTask()); | |||
| try { | |||
| const savedTask = await taskInstance.save((status: string, progress: number): void => { | |||
| dispatch(createTaskUpdateStatus(status + (progress !== null ? ` ${Math.floor(progress * 100)}%` : ''))); | |||
| dispatch(createTaskUpdateStatus(status + (progress ? ` ${Math.floor(progress * 100)}%` : ''))); | |||
There was a problem hiding this comment.
If the progress is 0, it does not show any progress. Maybe to keep !== null check?
There was a problem hiding this comment.
Ok, lets pass null if no progress has to be specified
bsekachev
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
In recent patches
onUpdatecvat-ui status callback signature was changed. Tus client upload used old signature that led to bug in progress bar:How has this been tested?
Manual testing
Checklist
developbranchI have updated the documentation accordinglyI have added tests to cover my changesI have linked related issues (read github docs)cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.