Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support any name for a manifest #4041

Merged
merged 7 commits into from
Dec 22, 2021
Merged

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Dec 16, 2021

Motivation and context

Resolve #3968

  • Added support for uploading a manifest with any name
  • Added manifest structure validation

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
    - [ ] I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro
Copy link
Contributor

@Marishka17 Hi, please also don't forget to update backup functionality as well https://github.com/openvinotoolkit/cvat/blob/develop/cvat/apps/engine/backup.py#L261

@Marishka17
Copy link
Contributor Author

@Marishka17 Hi, please also don't forget to update backup functionality as well https://github.com/openvinotoolkit/cvat/blob/develop/cvat/apps/engine/backup.py#L261

@azhavoro, Right now I'm not sure that I need to update it because the name manifest.jsonl will be used inside CVAT part.

@Marishka17 Marishka17 marked this pull request as ready for review December 20, 2021 09:07
@bsekachev bsekachev merged commit 5281e79 into develop Dec 22, 2021
@nmanovic nmanovic deleted the mk/support_any_name_for_manifest branch December 22, 2021 16:17
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task creation ignore manifest name in code
3 participants