Fixed codacy issues part 1 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azhavoro
force-pushed
the
az/fix_codacy_issues
branch
from
6b0c8b2
to
6e4c5c2
Compare
azhavoro
requested review from
nmanovic and
bsekachev
and removed request for
nmanovic
nmanovic
reviewed
Apr 16, 2019
cvat/apps/engine/serializers.py
Outdated
|
|
||
| def to_internal_value(self, data): | ||
| @staticmethod | ||
| def to_internal_value(data): |
There was a problem hiding this comment.
by specification the method should have self. Please find another way to fix the particular issue.
nmanovic
reviewed
Apr 16, 2019
cvat/apps/engine/serializers.py
Outdated
| return {'file': data} | ||
|
|
||
| def to_representation(self, instance): | ||
| @staticmethod | ||
| def to_representation(instance): |
There was a problem hiding this comment.
By specification the method should have self. Please find another way to fix the particular issue.
nmanovic
reviewed
Apr 16, 2019
cvat/apps/engine/serializers.py
Outdated
| @@ -183,7 +183,8 @@ class Meta: | |||
| write_once_fields = ('overlap', 'segment_size', 'image_quality') | |||
| ordering = ['-id'] | |||
|
|
|||
| def create(self, validated_data): | |||
| @staticmethod | |||
| def create(validated_data): | |||
There was a problem hiding this comment.
The same, it is an overloaded method of ModelSerializer. I don't think that we should remove self here.
nmanovic
reviewed
Apr 16, 2019
cvat/apps/engine/serializers.py
Outdated
| @@ -203,7 +204,8 @@ def create(self, validated_data): | |||
|
|
|||
| return db_task | |||
|
|
|||
| def update(self, instance, validated_data): | |||
| @staticmethod | |||
| def update(instance, validated_data): | |||
There was a problem hiding this comment.
Don't remove self here. Need another way to fix the issue.
|
@bsekachev , please review changes in JS code. |
bsekachev
approved these changes
Apr 17, 2019
azhavoro
force-pushed
the
az/fix_codacy_issues
branch
from
0cb4783
to
52df974
Compare
azhavoro
force-pushed
the
az/fix_codacy_issues
branch
from
52df974
to
bc559ab
Compare
nmanovic
approved these changes
Apr 17, 2019
TOsmanov
pushed a commit
to TOsmanov/cvat
that referenced
this pull request
Aug 23, 2021
* Start using attribute type in value casting * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.