Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full configuration of nuclio #3894

Merged
merged 3 commits into from
Nov 13, 2021

Conversation

subdavis
Copy link
Contributor

@subdavis subdavis commented Nov 10, 2021

Motivation and context

It is not currently possible to deploy nuclio properly into a cloud environment and connect it with a CVAT installation. Port and scheme are hard-coded even though Nuclio might be running behind a load balancer with HTTPS enabled.

How has this been tested?

Tested in docker compose using my own compose override file that adds these new environment variables.

Checklist

  • I submit my changes into the develop branch
  • I have added description of my changes into CHANGELOG file
  • I have updated the documentation accordingly Not applicable, no documentation for the existing feature exists, so nowhere to add.
  • I have added tests to cover my changes Not applicable, no tests exist
  • I have linked related issues (read github docs) Not applicable
  • I have increased versions of npm packages if it is necessary (cvat-canvas,
    cvat-core, cvat-data and cvat-ui)
    Not applicable

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below) Not applicable
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subdavis , thanks for the contribution. It looks fine. In general you always can redefine settings for your local CVAT instance (from cvat.settings.production import * and modify that you like, after that use DJANGO_SETTINGS_MODULE). But let's keep env variables to simplify things.

@nmanovic nmanovic merged commit 4487d52 into cvat-ai:develop Nov 13, 2021
@subdavis subdavis deleted the nuclio-configure-connection branch November 13, 2021 21:28
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants