Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about redis server in wsl #3828

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Add note about redis server in wsl #3828

merged 1 commit into from
Nov 5, 2021

Conversation

efcy
Copy link
Contributor

@efcy efcy commented Oct 26, 2021

This change adds a note about manually starting the redis server inside wsl. This is necessary because installing the redis-server package does not start it when systemd is not available.

Motivation and context

Multiple people ran into this problem and reported it on gitter. Also it's not obvious that you have to start it manually.

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)

@efcy efcy requested a review from nmanovic as a code owner October 26, 2021 19:49
@azhavoro
Copy link
Contributor

azhavoro commented Oct 27, 2021

@dvkruchinin Hi, could you please take a look at these issues:

  1. Remark check is failed, but no artifacts were uploaded
  2. Tests for 3D functionality are failed, but this PR cannot lead to this

@ActiveChooN
Copy link
Contributor

@StellaASchlotter, hi, thanks for the contribution. Personally, I start redis inside a docker for WSL without the necessity to start service manually. So, can you add a note about this case?

nmanovic
nmanovic previously approved these changes Oct 28, 2021
@@ -110,3 +110,4 @@ You develop CVAT under WSL (Windows subsystem for Linux) following next steps.
```

- Run all commands from this installation guide in WSL Ubuntu shell.
- You might have to manually start the redis server in wsl before you can start the configuration inside Visual Studio Code. You can do this with `sudo service redis-server start`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a very long line. Markdown linter complains about that: https://github.com/openvinotoolkit/cvat/actions/runs/1387241296 (see artifacts on the page)

@nmanovic
Copy link
Contributor

nmanovic commented Nov 3, 2021

@StellaASchlotter , will you have time to improve the PR a little bit?

@efcy
Copy link
Contributor Author

efcy commented Nov 3, 2021

@StellaASchlotter , will you have time to improve the PR a little bit?

I will do it tomorrow.

@efcy
Copy link
Contributor Author

efcy commented Nov 4, 2021

I hope I addressed all remarks. Let me know if I should change anything.

@nmanovic nmanovic merged commit e774991 into cvat-ai:develop Nov 5, 2021
@nmanovic
Copy link
Contributor

nmanovic commented Nov 5, 2021

@StellaASchlotter , great job! Thank you for your contributions.

@efcy efcy deleted the fix/wsl_dev_env branch January 19, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants