-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about redis server in wsl #3828
Conversation
@dvkruchinin Hi, could you please take a look at these issues:
|
@StellaASchlotter, hi, thanks for the contribution. Personally, I start redis inside a docker for WSL without the necessity to start service manually. So, can you add a note about this case? |
@@ -110,3 +110,4 @@ You develop CVAT under WSL (Windows subsystem for Linux) following next steps. | |||
``` | |||
|
|||
- Run all commands from this installation guide in WSL Ubuntu shell. | |||
- You might have to manually start the redis server in wsl before you can start the configuration inside Visual Studio Code. You can do this with `sudo service redis-server start` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a very long line. Markdown linter complains about that: https://github.com/openvinotoolkit/cvat/actions/runs/1387241296 (see artifacts on the page)
@StellaASchlotter , will you have time to improve the PR a little bit? |
I will do it tomorrow. |
I hope I addressed all remarks. Let me know if I should change anything. |
… usually not available per default.
@StellaASchlotter , great job! Thank you for your contributions. |
This change adds a note about manually starting the redis server inside wsl. This is necessary because installing the redis-server package does not start it when systemd is not available.
Motivation and context
Multiple people ran into this problem and reported it on gitter. Also it's not obvious that you have to start it manually.
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.