Cypress test. Connected file share. #3764
Conversation
…o dkru/cypress-test-case-106-connected-file-share
dvkruchinin
requested review from
azhavoro,
bsekachev and
nmanovic
as code owners
| cy.exec(`docker exec -i cvat /bin/bash -c "find ~/share -name "*.png" -type f"`) | ||
| .then((findFilesCommand) => { | ||
| // [image_case_107_2.png, image_case_107_3.png] | ||
| expect(findFilesCommand.stdout.split('\n').length).to.be.eq(2); | ||
| }); |
There was a problem hiding this comment.
Why need this check if the previous command
cy.exec(`mv ${assetLocalPath}/${stdoutToList[0]} ${assetLocalPath}/${stdoutToList[0]}.bk`)
.then((fileRenameCommand) => {
expect(fileRenameCommand.code).to.be.eq(0);
});
will return code 0?
There was a problem hiding this comment.
To make sure that the file has been renamed. And there are only 2 images used in the task. Checking the exit code of the rename command has been added just in case.
| }); | ||
| }); | ||
|
|
||
| it('Check "Fix problem with getting cloud storages in Firefox".', () => { |
There was a problem hiding this comment.
So, if this test doesn't have common with cloud storage features, maybe better to use a such message?
| it('Check "Fix problem with getting cloud storages in Firefox".', () => { | |
| it('Check "Fix DataCloneError: The object could not be cloned in Firefox".', () => { |
or
| it('Check "Fix problem with getting cloud storages in Firefox".', () => { | |
| it('Check "Fix problem with getting share data for the task when data not available more in Firefox".', () => { |
There was a problem hiding this comment.
I chose the second option. Applied locally.
Right now GitHub is having problems with actions. The jobs will start after the problems are fixed. https://www.githubstatus.com/
…o dkru/cypress-test-case-106-connected-file-share
| .should('be.visible') | ||
| .within(() => { | ||
| cy.get('[aria-label="plus-square"]').click(); | ||
| cy.get('[title]').should('have.length', 4); // Also "root" |
There was a problem hiding this comment.
Do we really need this check? It can have any other name actually and only specified in UI as "root". At the same time the name does not affect UX anyhow.
There was a problem hiding this comment.
Slightly overworked. I think this check is still needed. To check for the absence of extra lines.
…o dkru/cypress-test-case-106-connected-file-share
Motivation and context
Added new test to check the functionality of creating a task using "Connected file share".
Check PR #3733 (https://github.com/dvkruchinin/cvat/runs/3792189841?check_suite_focus=true#step:5:4627)
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.