Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uploading annotation #3677

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
//
// SPDX-License-Identifier: MIT

import React from 'react';
import React, { useState } from 'react';
import Menu from 'antd/lib/menu';
import Modal from 'antd/lib/modal';
// eslint-disable-next-line import/no-extraneous-dependencies
Expand Down Expand Up @@ -48,14 +48,13 @@ export default function AnnotationMenuComponent(props: Props): JSX.Element {
const jobStatus = jobInstance.status;
const taskID = jobInstance.task.id;

let latestParams: MenuInfo | null = null;
const [latestParams, setLatestParams] = useState<MenuInfo | null>(null);
function onClickMenuWrapper(params: MenuInfo | null, file?: File): void {
const copyParams = params || latestParams;
if (!copyParams) {
return;
}
latestParams = params;

setLatestParams(params);
function checkUnsavedChanges(_copyParams: MenuInfo): void {
if (jobInstance.annotations.hasUnsavedChanges()) {
Modal.confirm({
Expand Down Expand Up @@ -153,7 +152,7 @@ export default function AnnotationMenuComponent(props: Props): JSX.Element {
const is2d = jobInstance.task.dimension === DimensionType.DIM_2D;

return (
<Menu onClick={onClickMenuWrapper} className='cvat-annotation-menu' selectable={false}>
<Menu onClick={(info) => onClickMenuWrapper(info as MenuInfo)} className='cvat-annotation-menu' selectable={false}>
{LoadSubmenu({
loaders,
loadActivity,
Expand Down