Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix. Allow dots in image name for 3D formats #3633

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

sizov-kirill
Copy link
Contributor

Motivation and context

In #3612 it was noticed that 3D formats do not support images with dots in the name, this leads to a fall in the unit test.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max
Copy link
Contributor

Will you add the test?

As far as I remember, it was decided to put off this change till a user request comes. Because such change will make the output datasets incompatible with the formats.

@sizov-kirill
Copy link
Contributor Author

Will you add the test?

As far as I remember, it was decided to put off this change till a user request comes. Because such change will make the output datasets incompatible with the formats.

I made this PR to fix CI on the current develop branch. Why it will make the output datasets incompatible with the formats?

Now id of items (for 3d formats) differ for Task dumpinng and Project dumping, I just made these behaviors the same and supported dots in name:
https://github.com/openvinotoolkit/cvat/blob/25f0840c751062cdc8bd85750f1a6269b1821a99/cvat/apps/dataset_manager/bindings.py#L911-L913
https://github.com/openvinotoolkit/cvat/blob/25f0840c751062cdc8bd85750f1a6269b1821a99/cvat/apps/dataset_manager/bindings.py#L1015-L1017

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, probably I misread the change.

@sizov-kirill sizov-kirill merged commit bc2dc77 into develop Sep 2, 2021
@bsekachev bsekachev deleted the sk/allow-dots-in-3d-formats branch September 2, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants