Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress test. Update case 14. "Selected opacity" level of shapes being drawn. #3530

Conversation

dvkruchinin
Copy link
Contributor

Motivation and context

Cypress test for "Selected opacity" slider now defines opacity level of shapes being drawn. PR #3473

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin dvkruchinin requested a review from azhavoro as a code owner August 9, 2021 12:26
@bsekachev bsekachev self-assigned this Aug 10, 2021
@@ -162,5 +167,16 @@ context('Appearance features', () => {
cy.get('.cvat-appearance-outlinded-borders-checkbox').click();
cy.get('#cvat_canvas_shape_3').should('have.css', 'stroke', 'rgb(224, 224, 224)'); // have CSS property stroke with the value rgb(224, 224, 224)
});

it('"Selected opacity" slider now defines opacity level of shapes being drawn.', () => {
cy.interactControlButton('draw-rectangle');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also check it for polygons, polyline, points, and cuboids (for polyline, points it should not affect opacity level). For cuboids, it should affect opacity level only if draw using rectangle (BTW the same for rectangles, it should affect opacity level only if draw them using standard way [not using 4 points])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the appropriate steps.

@bsekachev bsekachev merged commit e153dcf into cvat-ai:develop Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants