-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Nginx proxy with Traefik #3409
Conversation
@nmanovic This PR is now ready for review |
@nmanovic Would you mind running the workflows here again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tadejsv Hi,
Thanks for the contribution, great job!
I have 2 comments:
- Could you please update the network section of https://github.com/openvinotoolkit/cvat/blob/develop/components/analytics/docker-compose.analytics.yml as well
- Please fix conflicts and linter issues for changelog.md
Thanks for the feedback, @azhavoro . I have implemented the changes you suggested. If you re-run the workflows, I think all tests should pass |
@tadejsv , great job! Thanks for the contribution. |
Motivation and context
This replaces the Nginx with a more "modern" proxy, Traefik.
There should be no change in the basic usage, i.e. the new
docker-compose.yml
file is a drop-in replacement for the old one. For using HTTPS the process becomes vastly simplified, and boils down to setting 2 env variables and using an override docker compose file.Apart from HTTPS, the only other noticeable user-facing change is that the hostname is no longer set by the
CVAT_HOST
env variable in the proxy service, but by theCVAT_HOST
env variable in the shell from which the user will execute the docker-compose command.Closes #3407.
How has this been tested?
I have tested the new
docker-compose.yml
file locally, and I have also tested thedocker-compose.https.yml
file on an EC2 instance with my own domain - HTTPS was properly set up, as expected. But it would be great if someone else would test this on their own, just to double-check.Also, I am not sure how this would work with proxy (in this sense). Should anyone be able to help me with checking this, that would be great.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.