Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make function get_progress be compatible with more video format #3381

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

Thatwho
Copy link
Contributor

@Thatwho Thatwho commented Jul 1, 2021

  • Add function _get_duration with VideoReader
  • Update function get_progress of VideoReader

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro
Copy link
Contributor

azhavoro commented Jul 1, 2021

@Thatwho Thanks for the your contribution!

@nmanovic
Copy link
Contributor

nmanovic commented Jul 1, 2021

@Thatwho , should we mention an issue which the PR resolves? Could you please add a line into CHANGELOG.md?

* Add function _get_duration with VideoReader
* Update function get_progress of VideoReader
@Thatwho Thatwho force-pushed the get_video_extract_progress branch from becd1a3 to 2a32f00 Compare July 1, 2021 16:40
CHANGELOG.md Outdated Show resolved Hide resolved
nmanovic
nmanovic previously approved these changes Jul 1, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@nmanovic nmanovic merged commit d2c7739 into cvat-ai:develop Jul 1, 2021
@nmanovic
Copy link
Contributor

nmanovic commented Jul 1, 2021

@Thatwho , thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_prpgress function of VideoReader can compatible with more video format
3 participants