-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with hung web worker #3096
Conversation
@maximusunc , thanks for the contribution. Could you please add information about the fix into CHANGELOG.md? |
@maximusunc , could you please update the version of cvat-core? Run |
* Added upper limit to stop property of active chunk request
b889a65
to
e8519af
Compare
e8519af
to
d3501d0
Compare
Hi @nmanovic Looking at the test output, it looks like the tests timed out while running some canvas3d tests. I don't think my changes had anything to do with this test failure, but I will wait to hear back from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maximusunc , thanks for the fix. For we it looks fine. All checks for the PR is OK.
Motivation and context
Fixes #3080. The unzip_imgs web worker was not getting terminated when loading the last chunk in a task. I added a stopFrame limit to the chunk request so that the web worker gets properly terminated once it unzips all images.
How has this been tested?
I manually tested this by uploading 71 frames, all 2048 x 2448 to exceed the cache limit, and made sure that the web worker is correctly terminated after loading the last chunk. I also made sure that scrolling back through the previous frames worked and that frames that had been removed from the cache are successfully loaded back in.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.