Cypress test. Repeat draw feature. #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
requested changes
Mar 2, 2021
|
|
||
| it('Draw and repeat draw a point.', () => { | ||
| cy.createPoint(createPointsShape); | ||
| cy.get('.cvat-canvas-container').trigger('mousemove', 750, 400); |
There was a problem hiding this comment.
As I see in points we do not check:
cy.get('#cvat_canvas_shape_5').should('have.class', 'cvat_canvas_shape_activated');
Is it intented? Why do we need this mousemove in this case?
There was a problem hiding this comment.
Removed the activation of the object before repeating the drawing
Comment on lines
111
to
116
| cy.get('.cvat_canvas_shape').then(($shape) => { | ||
| expect($shape.length).to.be.equal(6); | ||
| }); | ||
| cy.get('.cvat-objects-sidebar-state-item').then(($sidebarItem) => { | ||
| expect($sidebarItem.length).to.be.equal(6); | ||
| }); |
There was a problem hiding this comment.
One of these checks is extra IMHO
There was a problem hiding this comment.
Removed it. Left the object sidebar check
tests/cypress/integration/actions_tasks_objects/case_55_repeat_draw_feature.js
Show resolved
Hide resolved
…o dkru/cypress-test-case-55-repeat-draw-feature
bsekachev
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Add Cypress test.
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.