-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to mousetrap, redesigned visualization settings #2872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
border-radius: 6px 6px 0 0; | ||
border: 1px solid $border-color-3; | ||
z-index: 100; | ||
padding: 4px 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, should we use $grid-unit-size
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure because sometimes grid-unit-size (8px) looks too much in paddings, border radios, etc.
Motivation and context
Resolved #1839
All the shortcuts were tested manually.
How has this been tested?
Tests were updated
@dvkruchinin Please, check them.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.