Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: cannot close some issues #2868

Merged
merged 10 commits into from
Mar 3, 2021
Merged

Fixed: cannot close some issues #2868

merged 10 commits into from
Mar 3, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Feb 25, 2021

Motivation and context

Resolved #2607

Added ability to scroll issues under cursor with mousewheel

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Feb 25, 2021
@bsekachev bsekachev changed the title Squashed commits Fixed: cannot close some issues Feb 25, 2021
@bsekachev bsekachev requested a review from nmanovic as a code owner February 25, 2021 15:37
@bsekachev
Copy link
Member Author

@azhavoro
Could you please assist me? What is wrong with Linter / ESLint build?
It just ends with status 1 without any error output. Locally check in precommit hook was fine

@azhavoro
Copy link
Contributor

@azhavoro
Could you please assist me? What is wrong with Linter / ESLint build?
It just ends with status 1 without any error output. Locally check in precommit hook was fine

image
@bsekachev there are some unresolved path errors, but I think it's false positive, we will try to investigate with Dmitry this issue. Maybe some configuration is missing.
I also agree, it would be nice to see errors in the logs in addition to the report.

@dvkruchinin
Copy link
Contributor

@azhavoro
eslint here is configured to write the report to an html file. In this case, there is no output in stdout. Alternatively, run eslint 2 times. With output to stdout and to an html file.
@bsekachev
To solve the eslint error of the form I'm in PR #2867. I propose a solution in the form of an additional path in the path file .eslintrc. This is because eslint in CI runs in the root project dir. And he doesn't know anything about the src folder.
https://github.com/openvinotoolkit/cvat/pull/2867/files#diff-4742993204a8e6ed2cb760fa609942a509c42c6baee85790275cb5461c0e34a2

@coveralls
Copy link

coveralls commented Feb 25, 2021

Coverage Status

Coverage increased (+0.02%) to 71.72% when pulling 3b15baf on bs/fixed_issue_2607 into 638850a on develop.

@ActiveChooN
Copy link
Contributor

Maybe it's better to add notification or disable button open issue for objects with opened one, what do you think?

@bsekachev
Copy link
Member Author

bsekachev commented Feb 28, 2021

Maybe it's better to add notification or disable button open issue for objects with opened one, what do you think?

It does not prevent creating issue at the same position actually
But maybe it would be better to find a way close several issues for the same region

Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsekachev bsekachev merged commit d5312df into develop Mar 3, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_2607 branch March 3, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot close some issues
5 participants