Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call HOC component each render #2780

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Conversation

bsekachev
Copy link
Member

Motivation and context

Resolved #2753
The same issue for other popovers.

@dvkruchinin Could you please write a test with the next scenario:

  1. Open a task
  2. Open draw polygon popup, set 4 points to be drawn
  3. Draw a polygon
  4. Open the popup again
  5. Be sure that 4 points are still entered (empty value is expected before the fix)

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added bug Something isn't working customer High priority feature request labels Feb 8, 2021
@bsekachev
Copy link
Member Author

@ActiveChooN Could you please review the patch ASAP?

@coveralls
Copy link

coveralls commented Feb 8, 2021

Coverage Status

Coverage decreased (-0.02%) to 69.737% when pulling b826621 on bs/fixed_issue_2753 into 77acd7d on develop.

@dvkruchinin
Copy link
Contributor

@bsekachev

Could you please write a test with the next scenario

Of course, I will prepare a test for this scenario.

@bsekachev bsekachev merged commit 2da29e4 into develop Feb 9, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_2753 branch February 15, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer High priority feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Tools state reset after reopen
5 participants