-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVAT-3D Milestone2 #2645
CVAT-3D Milestone2 #2645
Conversation
…d created a relatedfiles table for PCD to Image mapping.
…ration Scripts and Dimension attribute for MpegChunk Writers
…ion accross classes
cvat-ui/src/components/annotation-page/standard3D-workspace/controls-side-bar/photo-context.tsx
Outdated
Show resolved
Hide resolved
cvat-ui/src/components/annotation-page/standard3D-workspace/controls-side-bar/photo-context.tsx
Outdated
Show resolved
Hide resolved
Could you please answer my question?
|
Hi @bsekachev, we shall be adding the code for preview corresponding to pcd files in the next Milestone PR since we need to do more R&D on the same. |
@@ -475,6 +477,23 @@ def data(self, request, pk): | |||
|
|||
elif data_type == 'preview': | |||
return sendfile(request, frame_provider.get_preview()) | |||
|
|||
elif data_type == 'context_image': | |||
if db_task.dimension == DimensionType.DIM_3D: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azhavoro , @Marishka17 ,
Could you please give some ideas how to implement the functionality in accordance with our general strategy? I believe the information should follow the same way as images and video frames. Probably it should be packed together with PCD data, cached.
How does it work in case of share? Will it be copied on the fly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only one major comment. I believe the way we provide context images from server to clients isn't correct. I'm OK to address that in next PRs but need to have a clear strategy here.
@manasars , could you please update CONTRIBUTION.md guide (how to build) and CHANGELOG.md (which features were added)? |
@manasars Here are a couple of conflicts appeared |
Hi @bsekachev , fixed the merge conflicts. |
CVAT-3D-Milestone2 : Load all frames corresponding to the job instance - 3D View
Changes include:
Loading all the frames corresponding to the job in the current instance.
View active PCD file/frame on the screen.
Map the image file with the corresponding pcd file.
Created sub-project canvas-3D for 3D annotations.
Implemented functionality for photo context hide/show.
Implement frame navigation using arrows to move to next/previous frame.
Test Cases:
Manual Unit testing done locally.
Existing test cases work as expected.
System Test cases will be shared.
[x ] I submit my changes into the develop branch
[ x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.