Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVAT-3D Milestone2 #2645

Merged
merged 76 commits into from
Feb 5, 2021
Merged

CVAT-3D Milestone2 #2645

merged 76 commits into from
Feb 5, 2021

Conversation

manasars
Copy link
Contributor

@manasars manasars commented Jan 5, 2021

CVAT-3D-Milestone2 : Load all frames corresponding to the job instance - 3D View

Changes include:
Loading all the frames corresponding to the job in the current instance.
View active PCD file/frame on the screen.
Map the image file with the corresponding pcd file.
Created sub-project canvas-3D for 3D annotations.
Implemented functionality for photo context hide/show.
Implement frame navigation using arrows to move to next/previous frame.

Test Cases:
Manual Unit testing done locally.
Existing test cases work as expected.
System Test cases will be shared.

[x ] I submit my changes into the develop branch

[ x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

cdp added 30 commits December 7, 2020 13:11
…d created a relatedfiles table for PCD to Image mapping.
…ration Scripts and Dimension attribute for MpegChunk Writers
cvat-canvas3d/.gitignore Outdated Show resolved Hide resolved
cvat-canvas3d/src/scss/canvas.scss Outdated Show resolved Hide resolved
cvat-canvas3d/src/scss/canvas.scss Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3d.ts Outdated Show resolved Hide resolved
cvat-canvas3d/README.md Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3d.ts Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3d.ts Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3dView.ts Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3dView.ts Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3dView.ts Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3dView.ts Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3dView.ts Outdated Show resolved Hide resolved
cvat-canvas3d/src/typescript/canvas3dView.ts Outdated Show resolved Hide resolved
@bsekachev
Copy link
Member

@manasars

Could you please answer my question?

The same preview for different data when create a task. Is it expected?

@manasars
Copy link
Contributor Author

manasars commented Feb 1, 2021

Hi @bsekachev, we shall be adding the code for preview corresponding to pcd files in the next Milestone PR since we need to do more R&D on the same.

bsekachev
bsekachev previously approved these changes Feb 2, 2021
@@ -475,6 +477,23 @@ def data(self, request, pk):

elif data_type == 'preview':
return sendfile(request, frame_provider.get_preview())

elif data_type == 'context_image':
if db_task.dimension == DimensionType.DIM_3D:
Copy link
Contributor

@nmanovic nmanovic Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azhavoro , @Marishka17 ,

Could you please give some ideas how to implement the functionality in accordance with our general strategy? I believe the information should follow the same way as images and video frames. Probably it should be packed together with PCD data, cached.

How does it work in case of share? Will it be copied on the fly?

nmanovic
nmanovic previously approved these changes Feb 2, 2021
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one major comment. I believe the way we provide context images from server to clients isn't correct. I'm OK to address that in next PRs but need to have a clear strategy here.

@nmanovic
Copy link
Contributor

nmanovic commented Feb 2, 2021

@manasars , could you please update CONTRIBUTION.md guide (how to build) and CHANGELOG.md (which features were added)?

@manasars manasars dismissed stale reviews from nmanovic and bsekachev via 3d53bd5 February 2, 2021 10:13
@manasars
Copy link
Contributor Author

manasars commented Feb 2, 2021

@manasars , could you please update CONTRIBUTION.md guide (how to build) and CHANGELOG.md (which features were added)?

Hi @nmanovic , updated the CHANGELOG.md file, no changes in CONTRIBUTION.md since we don't see any changes in build as of now.

bsekachev
bsekachev previously approved these changes Feb 3, 2021
@bsekachev
Copy link
Member

@manasars Here are a couple of conflicts appeared

@manasars
Copy link
Contributor Author

manasars commented Feb 5, 2021

@manasars Here are a couple of conflicts appeared

Hi @bsekachev , fixed the merge conflicts.

@bsekachev bsekachev merged commit 5c67846 into cvat-ai:develop Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants