Cypress test. Settings player step. #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2020 18:01
|
@DmitriyOparin Please recheck the test for the current develop branch. |
DmitriyOparin
changed the title
|
Recheck of test is success for the current develop branch. |
DmitriyOparin
changed the title
bsekachev
reviewed
Dec 10, 2020
|
|
||
| describe(`Testing case "${caseId}"`, () => { | ||
| it('Change player step ', () => { | ||
| changePlayerStep(); |
There was a problem hiding this comment.
What is reason to make a separated function here? The code is used only here as I can see.
There was a problem hiding this comment.
I thought this function will be use in several steps. It changed now.
Comment on lines
32
to
39
| // get and save current step | ||
| cy.get('.cvat-player-frame-selector').within(() => { | ||
| cy.get('[role="spinbutton"]') | ||
| .should('have.attr', 'aria-valuenow') | ||
| .then((valueStepNow) => { | ||
| startStep = Number(valueStepNow); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
In this code you get not a current step, you get initial frame. So, I would rename "startStep" to "initialFrame" or "startFrame"
There was a problem hiding this comment.
Thanks. Variable renamed.
bsekachev
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress test. Settings player step.
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.