Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dedicated component for label selection, added tooltip #2509

Merged
merged 9 commits into from
Dec 2, 2020

Conversation

bsekachev
Copy link
Member

Motivation and context

Resolve #2461
Reduced code duplication

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the enhancement New feature or request label Nov 30, 2020
@bsekachev bsekachev changed the title Added dedicated component for label selector, added tooltip Added dedicated component for label selection, added tooltip Nov 30, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 63.187% when pulling 3d97c3b on bs/label_selector_refactoring into 6f3c0cb on develop.

ActiveChooN
ActiveChooN previously approved these changes Dec 2, 2020
Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature

@bsekachev bsekachev merged commit 0c986a3 into develop Dec 2, 2020
@bsekachev bsekachev deleted the bs/label_selector_refactoring branch December 2, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support longer label naming
3 participants