Don't export outside frames in frame-based formats #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiltsov-max
force-pushed
the
zm/dont-export-ouside
branch
from
a29446d to
05ffe2e
Compare
azhavoro
approved these changes
Oct 22, 2020
nmanovic
reviewed
Oct 22, 2020
| @@ -268,6 +268,8 @@ def get_frame(idx): | |||
| for shape in sorted(anno_manager.to_shapes(self._db_task.data.size), | |||
| key=lambda shape: shape.get("z_order", 0)): | |||
| if 'track_id' in shape: | |||
| if shape['outside']: | |||
There was a problem hiding this comment.
@zhiltsov-max , will the code work correctly for the case when a user wants to dump annotations in CVAT for video format? Because the format has to include outside frames with explicit outside=1. Could you please remind me how the case will be handled?
There was a problem hiding this comment.
This function is not used in that format.
nmanovic
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Fixes the problem with
CVAT for imagesexport - first track frames markedoutsidewere presented in the output files.Closes #2339
How has this been tested?
Unit test, manual test.
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.