Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for prettier auto formatter #2318

Closed
wants to merge 3 commits into from

Conversation

vnishukov
Copy link
Contributor

@vnishukov vnishukov commented Oct 13, 2020

Motivation and context

Make pre commit hook and auto format applicable to whole project, not only ui module
Also make fixes for json, yml, and md file formatting

How has this been tested?

Just make some changes in file of json, yml, md and try to commit

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.695% when pulling e7f0b3b on prettier_improvements into 29170ca on develop.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev , it looks fine for me. If you are OK as well, please merge.

@bsekachev
Copy link
Member

bsekachev commented Oct 14, 2020

@nmanovic @vnishukov

As I said in other PR #2311, it doesn't look well when I need to change only a couple of lines of code and precommit brings a lot of change per every modified file. In this PR for example I changed 4-10 lines of code, but PR shows almost 300 changes

It makes code review difficult and not obvious what changes in the code directed to solve an issue. It especially becomes difficult to review when we introduce big features (like projects from Dmitri), because of too much extra code changes not related with PR.

Can we do something with it? (I would suggest run automatic linter checks & fixes only for changed rows in a PR). Now I have to disable this feature in my patches by removing corresponding lines from package.json

@vnishukov vnishukov closed this Oct 15, 2020
@vnishukov
Copy link
Contributor Author

Need additional discussion

@vnishukov vnishukov deleted the prettier_improvements branch October 15, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants