Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to search for an empty frame #2221

Merged
merged 7 commits into from
Sep 28, 2020
Merged

Conversation

bsekachev
Copy link
Member

Motivation and context

Added ability to search empty frames.
The request is from our data annotation team.

Added switcher to player buttons next/previous that supports three kinds of navigation:

  • regular navigation (as it was)
  • navigation using filter search (as it was implemented using arrows)
  • navigation till the nearest empty frame

Right click to a current navigation button opens switcher, then you can use other kind of navigation clicking it. It will change default behavior (including shortcuts)
Screenshot from 2020-09-24 20-34-58

Resolve #2214
Resolve #284

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the enhancement New feature or request label Sep 24, 2020
@bsekachev bsekachev changed the title Bs/empty frames search [WIP] Added ability to search for an empty frame Sep 24, 2020
@bsekachev bsekachev requested a review from nmanovic as a code owner September 24, 2020 18:27
@bsekachev bsekachev changed the title [WIP] Added ability to search for an empty frame Added ability to search for an empty frame Sep 24, 2020
@coveralls
Copy link

coveralls commented Sep 24, 2020

Coverage Status

Coverage decreased (-0.5%) to 64.858% when pulling 9d86b3e on bs/empty_frames_search into d4b0e11 on develop.

@bsekachev bsekachev force-pushed the bs/empty_frames_search branch from b0c0a40 to 9d86b3e Compare September 24, 2020 19:52
@Loc-Vo
Copy link

Loc-Vo commented Sep 26, 2020

Can we also have the statistics of empty frames included in the INFO panel for status tracking as well?

@bsekachev
Copy link
Member Author

@s3298230

Can we also have the statistics of empty frames included in the INFO panel for status tracking as well?

Please, submit a github issue. It looks like not difficult, but separated feature.

@bsekachev bsekachev merged commit a5b2229 into develop Sep 28, 2020
@ActiveChooN ActiveChooN deleted the bs/empty_frames_search branch September 28, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching frames without annotation Ability to use the filter to find empty frames
4 participants