Added ability to correct upload video with a rotation record in the metadata #2218
Conversation
|
If a video was loaded with a rotation record in the metadata and the 'Use cache' checkbox was enabled, incorrect sizes will be saved. |
|
@Marishka17 , what is the status of the PR? |
|
I left out one moment, that we don't have installed |
Marishka17
changed the title
Marishka17
changed the title
Marishka17
changed the title
| frame = av.VideoFrame().from_ndarray( | ||
| rotate_image( | ||
| frame.to_ndarray(format='bgr24'), | ||
| 360 - int(container.streams.video[0].metadata.get('rotate')) |
There was a problem hiding this comment.
I have a couple of questions here:
- what the method returns: video_stream.metadata.get('rotate')?
- what is the difference between previous expression and container.streams.video[0].metadata.get('rotate')
- can container.streams.video[0].metadata.get('rotate') be always converted to int?
There was a problem hiding this comment.
what the method returns: video_stream.metadata.get('rotate')?
string of rotation angle
what is the difference between previous expression and container.streams.video[0].metadata.get('rotate')
this is analogue
can container.streams.video[0].metadata.get('rotate') be always converted to int?
I checked for some values like 60, 90, 180, 270.. and in such cases - yes
| @@ -177,6 +195,14 @@ def frame_sizes(self): | |||
| container.seek(offset=next(iter(self.key_frames.values())), stream=video_stream) | |||
| for packet in container.demux(video_stream): | |||
| for frame in packet.decode(): | |||
| if video_stream.metadata.get('rotate'): | |||
| @@ -74,3 +75,16 @@ def av_scan_paths(*paths): | |||
| res = subprocess.run(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE) | |||
| if res.returncode: | |||
| raise ValidationError(res.stdout) | |||
|
|
|||
| def rotate_image(image, angle): | |||
There was a problem hiding this comment.
Should we support rotation which isn't multiply pi/2 by an integer? Is it a real case to rotate a frame by 30 degrees? Is it possible at all?
There was a problem hiding this comment.
Artificially (write the desired value in the metadata) you can create such a video.
Motivation and context
Ability to correct upload video with a rotation record in the metadata
How has this been tested?
Manual, tests
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.