Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac OS dependencies notes #2177

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Add Mac OS dependencies notes #2177

merged 7 commits into from
Sep 24, 2020

Conversation

vnishukov
Copy link
Contributor

@vnishukov vnishukov commented Sep 15, 2020

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Sep 15, 2020

Coverage Status

Coverage remained the same at 65.356% when pulling 4ca1980 on eh/contributing_macos_notes into 7456a1c on develop.

Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add your changes to CHANGELOG.md file?

CONTRIBUTING.md Outdated Show resolved Hide resolved
@vnishukov
Copy link
Contributor Author

Could you also add your changes to CHANGELOG.md file?

Add notes to CHANGELOG.md

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@vnishukov vnishukov requested a review from nmanovic September 23, 2020 09:51
@nmanovic nmanovic merged commit d4b0e11 into develop Sep 24, 2020
@nmanovic nmanovic deleted the eh/contributing_macos_notes branch September 24, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants