Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Tracking with serverless functions #2136

Merged
merged 8 commits into from
Sep 8, 2020
Merged

UI Tracking with serverless functions #2136

merged 8 commits into from
Sep 8, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Sep 7, 2020

Screenshot from 2020-09-07 11-27-26
Screenshot from 2020-09-07 11-27-32
Screenshot from 2020-09-07 11-27-11

Motivation and context

The patch uses server-side implemented serverless tracking to get automatic bounding boxes on client.

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the enhancement New feature or request label Sep 7, 2020
@bsekachev bsekachev requested a review from nmanovic as a code owner September 7, 2020 08:39
@coveralls
Copy link

coveralls commented Sep 7, 2020

Pull Request Test Coverage Report for Build 7318

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.809%

Totals Coverage Status
Change from base Build 7306: 0.0%
Covered Lines: 12498
Relevant Lines: 17258

💛 - Coveralls

canvasInstance.interact({
enabled: true,
shapeType: 'points',
minPosVertices: 4, // TODO: Add parameter to interactor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use parameter min_pos_points. By default, the value should be 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JS I would prefer to use camelCase even if from the server we get snake_case as it done for all model fields in cvat-core (model, user, etc.). Knowing exact fields that we get from server we always can rename them in cvat-core

If we set value 1 here, DEXTR will not work correctly. First need to add parameter to all interactors

@nmanovic nmanovic merged commit 4e21929 into develop Sep 8, 2020
@nmanovic nmanovic deleted the bs/ui_tracking branch September 8, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants