-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Tracking with serverless functions #2136
Conversation
Pull Request Test Coverage Report for Build 7318
💛 - Coveralls |
canvasInstance.interact({ | ||
enabled: true, | ||
shapeType: 'points', | ||
minPosVertices: 4, // TODO: Add parameter to interactor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use parameter min_pos_points. By default, the value should be 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In JS I would prefer to use camelCase even if from the server we get snake_case
as it done for all model fields in cvat-core (model, user, etc.). Knowing exact fields that we get from server we always can rename them in cvat-core
If we set value 1
here, DEXTR will not work correctly. First need to add parameter to all interactors
Motivation and context
The patch uses server-side implemented serverless tracking to get automatic bounding boxes on client.
How has this been tested?
Manual testing
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.