Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added django-rq to the proxy match pattern. #2069

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Aug 24, 2020

Added django-rq to the proxy match pattern.

Motivation and context

http://localhost:8080/django-rq/ doesn't work as expected.

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@azhavoro azhavoro requested a review from nmanovic as a code owner August 24, 2020 08:39
@coveralls
Copy link

coveralls commented Aug 24, 2020

Pull Request Test Coverage Report for Build 7070

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 69.72%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 2 76.99%
Totals Coverage Status
Change from base Build 7059: 0.01%
Covered Lines: 11748
Relevant Lines: 16392

💛 - Coveralls

@@ -12,24 +12,11 @@ server {
proxy_set_header Host $http_host;
proxy_pass_header Set-Cookie;

location ~* /api/.*|git/.*|analytics/.*|static/.*|admin|admin/.*|documentation/.* {
location ~* /api/.*|git/.*|analytics/.*|static/.*|admin(?:/(.*))?.*|documentation/.*|django-rq(?:/(.*))? {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azhavoro , I believe we have a duplication of the file in documentation. Could you please update all places?

@nmanovic nmanovic merged commit 1907b79 into develop Aug 24, 2020
@nmanovic nmanovic deleted the az/fix_proxy_config branch August 24, 2020 10:46
@nmanovic nmanovic restored the az/fix_proxy_config branch August 24, 2020 10:46
@nmanovic nmanovic deleted the az/fix_proxy_config branch August 24, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants