-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Siammask tracker as DL serverless function #1988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
changed the title
siammask tracker as DL serverless function
[WIP] siammask tracker as DL serverless function
Aug 5, 2020
This was
linked to
issues
Aug 5, 2020
nmanovic
changed the title
[WIP] siammask tracker as DL serverless function
Siammask tracker as DL serverless function
Aug 5, 2020
@azhavoro , could you please look at the PR? I see that we have a problem with build. Could you please investigate and fix? |
Pull Request Test Coverage Report for Build 6800
💛 - Coveralls |
azhavoro
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Add support of tracker serverless functions into Lambda Manager. Also add SiamMask tracker as a DL serverless function.
The whole idea is trivial. To transform a tracker to DL serverless function it should return its
state
on each call. In the beginning the state is None and we sendshape
instead to initialize the tracker. After that it is necessary to sendstate
for each new call of the function to continue the tracking procedure.An idea for the future: now we use requests only to submit data to DB. It will be great if we have two types of requests: online and offline. Online requests will send results directly to UI at the end. Offline requests will send results to DB as now.
Note: it seems it will not be easy to convert other trackers to DL serverless functions because they hide own state usually. Every time need to implement encode_state and decode_state functions to serialize/deserialize a state to/from JSON. It should not be a problem for python native trackers because python cannot truly incapsulate anything but it is necessary to understand what is a state for a tracker.
Note: it was pain to integrate conda to docker. It is a good example that implementation of a DL serverless function can be non-trivial.
How has this been tested?
Manually. I used model_handler.py from the PR with demo.py from SiamMask GitHub repo and saw that I got the same tracking results.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.