Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datumaro] Add rounding for coordinates #1970

Merged
merged 4 commits into from
Aug 4, 2020
Merged

[Datumaro] Add rounding for coordinates #1970

merged 4 commits into from
Aug 4, 2020

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Coordinate rounding allows to reduce annotation file sizes and produce more comparable annotations.

  • Added rounding for shape coordinates up to 2 digits
  • Fixed polygon area computation

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Jul 31, 2020

Pull Request Test Coverage Report for Build 6763

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 69.116%

Totals Coverage Status
Change from base Build 6761: 0.05%
Covered Lines: 11147
Relevant Lines: 15621

💛 - Coveralls

@nmanovic
Copy link
Contributor

nmanovic commented Aug 4, 2020

@azhavoro , could you please look at the PR?

@azhavoro
Copy link
Contributor

azhavoro commented Aug 4, 2020

@zhiltsov-max Could you please update CHANGELOG.md?

@zhiltsov-max
Copy link
Contributor Author

@azhavoro, it is updated, what do you mean?

@azhavoro
Copy link
Contributor

azhavoro commented Aug 4, 2020

@azhavoro, it is updated, what do you mean?

v1.1.0-beta was released yesterday, so I think your change notes should be moved to the [1.1.0] - Unreleased topic.

@zhiltsov-max
Copy link
Contributor Author

Done

@nmanovic nmanovic merged commit 2c38cb4 into develop Aug 4, 2020
@nmanovic nmanovic deleted the zm/dm-rounding branch August 4, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants