Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React UI] A couple of fixes #1966

Merged
merged 4 commits into from
Jul 30, 2020
Merged

[React UI] A couple of fixes #1966

merged 4 commits into from
Jul 30, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 30, 2020

Motivation and context

Fixed one issue related with cached data and probably some ambiguity in data streaming
Added error message for case when plugins could not be initialized (infinite loading was before)

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1944
Related #1965

@bsekachev bsekachev added the bug Something isn't working label Jul 30, 2020
@coveralls
Copy link

coveralls commented Jul 30, 2020

Pull Request Test Coverage Report for Build 6686

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 105 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 69.062%

Files with Coverage Reduction New Missed Lines %
src/frames.js 3 23.31%
src/session.js 102 54.35%
Totals Coverage Status
Change from base Build 6672: 0.02%
Covered Lines: 11182
Relevant Lines: 15673

💛 - Coveralls

@bsekachev bsekachev merged commit f6c3965 into develop Jul 30, 2020
@nmanovic nmanovic deleted the bs/batch_of_fixes branch July 30, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning to job list for a task and attempting to start another job results in infinite loading screen.
3 participants