Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVAT UI: batch of fixes #1955

Merged
merged 3 commits into from
Jul 29, 2020
Merged

CVAT UI: batch of fixes #1955

merged 3 commits into from
Jul 29, 2020

Conversation

ActiveChooN
Copy link
Contributor

Motivation and context

Resolve #1825
Also resolved few linting isuues

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ActiveChooN ActiveChooN requested a review from bsekachev as a code owner July 28, 2020 17:07
@ActiveChooN ActiveChooN requested a review from nmanovic as a code owner July 28, 2020 17:08
@coveralls
Copy link

coveralls commented Jul 28, 2020

Pull Request Test Coverage Report for Build 6639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 64.988%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 7 75.52%
Totals Coverage Status
Change from base Build 6627: -0.03%
Covered Lines: 11097
Relevant Lines: 16675

💛 - Coveralls

@@ -18,8 +18,8 @@ import ConnectedFileManager, {
} from 'containers/file-manager/file-manager';
import { ModelFiles } from 'reducers/interfaces';

import CreateModelForm, {
CreateModelForm as WrappedCreateModelForm,
import WrappedCreateModelForm, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default export in this file is not wrapped model form, is a wrapper for model form

@bsekachev bsekachev merged commit 667a3f9 into develop Jul 29, 2020
@bsekachev bsekachev deleted the dk/batch-of-fixes branch July 29, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip should be hidden after mouse is out of an element
3 participants