Added ability to change user password #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6793
💛 - Coveralls |
bsekachev
requested changes
Jul 29, 2020
cvat-ui/src/reducers/interfaces.ts
Outdated
| @@ -13,6 +13,10 @@ export interface AuthState { | |||
| initialized: boolean; | |||
| fetching: boolean; | |||
| user: any; | |||
| authActionsFetching: boolean; | |||
| authActionsInitialized: boolean, | |||
Comment on lines
1
to
40
| // Copyright (C) 2020 Intel Corporation | ||
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| import { connect } from 'react-redux'; | ||
| import ChangePasswordModalComponent from 'components/change-password-modal/change-password-modal'; | ||
| import { CombinedState } from 'reducers/interfaces'; | ||
| import { changePasswordAsync } from 'actions/auth-actions'; | ||
|
|
||
| interface StateToProps { | ||
| fetching: boolean; | ||
| visible: boolean; | ||
| } | ||
|
|
||
| interface DispatchToProps { | ||
| onChangePassword( | ||
| oldPassword: string, | ||
| newPassword1: string, | ||
| newPassword2: string): void; | ||
| } | ||
|
|
||
| function mapStateToProps(state: CombinedState): StateToProps { | ||
| return { | ||
| fetching: state.auth.fetching, | ||
| visible: state.auth.showChangePasswordDialog, | ||
| }; | ||
| } | ||
|
|
||
| function mapDispatchToProps(dispatch: any): DispatchToProps { | ||
| return ({ | ||
| onChangePassword(oldPassword: string, newPassword1: string, newPassword2: string): void { | ||
| dispatch(changePasswordAsync(oldPassword, newPassword1, newPassword2)); | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| export default connect( | ||
| mapStateToProps, | ||
| mapDispatchToProps, | ||
| )(ChangePasswordModalComponent); |
There was a problem hiding this comment.
I believe we can move it to components/change-password-modal/change-password-modal and remove this file. No need to have separated container file to getting state from redux storage.
| ); | ||
| } | ||
|
|
||
| export default withRouter(ChangePasswordComponent); |
There was a problem hiding this comment.
I don't see how you use RouterProps here
|
Could you please also take a look at this PR? |
|
@azhavoro Please, update minor versions for |
ActiveChooN
reviewed
Jul 29, 2020
| } & FormComponentProps; | ||
|
|
||
| class ChangePasswordFormComponent extends React.PureComponent<ChangePasswordFormProps> { | ||
| private validateConfirmation = (rule: any, value: any, callback: any): void => { |
There was a problem hiding this comment.
@azhavoro, parameters type can be more strict than any
|
@azhavoro, can you also fix linting problems related to your PR, please? |
|
@zhiltsov-max , could you please look at the PR and test it? |
ActiveChooN
approved these changes
Aug 6, 2020
zhiltsov-max
approved these changes
Aug 6, 2020
nmanovic
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to change user password
How has this been tested?
Manual testing
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.