Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tricky handling of a caret position in input element #1923

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jul 21, 2020

Motivation and context

Resolve #1919
Antd API is not enough to implement it. Some tricks with react hooks are used.

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev requested a review from nmanovic as a code owner July 21, 2020 11:33
@bsekachev bsekachev requested a review from ActiveChooN July 21, 2020 11:35
@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 6536

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 64.949%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/extractor.py 1 90.67%
cvat/apps/engine/media_extractors.py 7 75.52%
Totals Coverage Status
Change from base Build 6516: -0.04%
Covered Lines: 11057
Relevant Lines: 16620

💛 - Coveralls

@bsekachev bsekachev merged commit 8bacccc into develop Jul 23, 2020
@bsekachev bsekachev deleted the bs/tricky_input branch July 29, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVAT new UI: text attribute mapping
3 participants