Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT-UI]: Appearance settings in AAM, keyframe navigation and other buttons in AAM #1820

Merged
merged 13 commits into from
Jul 2, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 29, 2020

Motivation and context

Implementation of some features that have been requested by internal team

Changes:

  • Component/container refactoring to reuse existing components in different places. Some files have been spitted because a lot of components in the same file.
  • Appearance block in AAM
  • Block with some switchers in AAM

Resolve #1423
Resolve #1422

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Screenshot from 2020-06-29 22-49-42

@bsekachev bsekachev added the enhancement New feature or request label Jun 29, 2020
@bsekachev bsekachev requested a review from ActiveChooN June 29, 2020 19:53
@coveralls
Copy link

coveralls commented Jun 29, 2020

Pull Request Test Coverage Report for Build 6281

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 65.154%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/extractor.py 1 91.01%
Totals Coverage Status
Change from base Build 6272: -0.009%
Covered Lines: 11049
Relevant Lines: 16548

💛 - Coveralls

@ActiveChooN
Copy link
Contributor

@bsekachev, get some issue when changed between frames/objects.

aam_tags_canvas_failure_1

@bsekachev
Copy link
Member Author

@ActiveChooN

Try to hide a rect or do it outside, then open AAM and go to this shape and you get the same result in develop,
But in this patch I tried to fix it. It seems not completely. I need specific info about shape where you get such a result

@ActiveChooN
Copy link
Contributor

ActiveChooN commented Jun 30, 2020

@bsekachev, if I enter the wrong filter or filter with empty result then the filter input field disappears. So i need to change standard mode to fix filter.

@ActiveChooN
Copy link
Contributor

@bsekachev, also i have an idea. It is not directly related with this PR. I guess it will be more convenient to start attributes shortcuts ordering from 1 not from 0, like it placed on keyboard. So label attribute shortcuts will be 1, 2 ... 9, 0 and not 0, 1, 2 ... 9.

@bsekachev
Copy link
Member Author

@bsekachev, also i have an idea. It is not directly related with this PR. I guess it will be more convenient to start attributes shortcuts ordering from 1 not from 0, like it placed on keyboard. So label attribute shortcuts will be 1, 2 ... 9, 0 and not 0, 1, 2 ... 9.

We use 0,1,2,3 because of historycal reasons. Our annotators use numpad keyboard.
We can discuss the idea on the meeting, but I think there won't be positive feedback from annotators

@bsekachev bsekachev requested a review from nmanovic as a code owner July 2, 2020 11:02
@bsekachev
Copy link
Member Author

@bsekachev, if I enter the wrong filter or filter with empty result then the filter input field disappears. So i need to change standard mode to fix filter.

Again, the same in develop. But I fixed it here.

@bsekachev bsekachev merged commit 757f0ad into develop Jul 2, 2020
@bsekachev bsekachev deleted the bs/aam_updates branch July 3, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants