Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuation of https://github.com/opencv/cvat/pull/1641 #1793

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

412b
Copy link
Contributor

@412b 412b commented Jun 23, 2020

Added env variables for Postgres DB and user names

Motivation and context

Configurable DB name and user name are standard

How has this been tested?

No special testing is needed, fallback in case of missing env vars is the previous value

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Added env variables for Postgres DB and user names
@412b 412b requested a review from nmanovic as a code owner June 23, 2020 10:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6095

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 65.416%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 2 77.06%
Totals Coverage Status
Change from base Build 6062: -0.009%
Covered Lines: 10994
Relevant Lines: 16395

💛 - Coveralls

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@nmanovic nmanovic merged commit 5d2f313 into cvat-ai:develop Jun 23, 2020
@412b 412b deleted the more-postgres-env-settings branch June 23, 2020 12:34
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
Added env variables for Postgres DB and user names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants