Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of single boxes in MOT format #1764

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 19, 2020

Implements the use case found in #1463

Motivation and context

Extends MOT format support with import of single boxes (without tracks). This is an extension for the original format, as it does not expect non-track annotations.

How has this been tested?

Unit test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max requested a review from azhavoro June 19, 2020 09:26
@zhiltsov-max zhiltsov-max requested a review from nmanovic as a code owner June 19, 2020 09:26
@coveralls
Copy link

coveralls commented Jun 19, 2020

Pull Request Test Coverage Report for Build 6061

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 65.425%

Totals Coverage Status
Change from base Build 6058: 0.03%
Covered Lines: 10996
Relevant Lines: 16395

💛 - Coveralls

@zhiltsov-max zhiltsov-max changed the title Allow single boxes in MOT format Allow import of single boxes in MOT format Jun 19, 2020
azhavoro
azhavoro previously approved these changes Jun 19, 2020
@@ -45,6 +45,17 @@ def _import(src_file, task_data):

track_id = ann.attributes.get('track_id')
if track_id is None:
# Extension. Import regular boxes:
task_data.add_shape(task_data.LabeledShape(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't create a track with only one bounding box?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it any better? This would not preserve the original annotations, as all tracks are exported as tracks, even single-framed. We can, possibly, convert regular boxes to such tracks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOT is for tracks only. Right? How are you going to dump a track which has two shapes:

  • First with outside=False, frame=0
  • Second with outside=True, frame=1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MOT is mostly for tracks, look here: https://motchallenge.net/instructions/. Almost every version has <[track] id> field set (idx 2), but not MOT17det, which contains just boxes and -1 as id. So we can safely assume that bboxes are supported via this extension.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@nmanovic nmanovic merged commit f646589 into develop Jun 22, 2020
@bsekachev bsekachev deleted the zm/allow-single-boxes-in-mot branch June 25, 2020 10:49
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
* Allow single boxes in MOT format

* update changelog

Co-authored-by: Nikita Manovich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants