Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Added shortcuts & ability to search a label #1683

Merged
merged 9 commits into from
Jun 15, 2020

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jun 9, 2020

  • Added shortcuts:
    • Change color [Press ENTER when object is activated]
    • Switch split mode [Alt + M]
  • Added ability to search label when create an object or change a label in the side panel
  • Added python-tk to installation guide. Debug server doesn't work for me without
  • Resolved some eslint & remarklint issues

Motivation and context

The PR provides some features that was requested by community and data annotation team

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1656
Resolve #1645
Resolve #1442

@bsekachev bsekachev added the enhancement New feature or request label Jun 9, 2020
@bsekachev bsekachev requested a review from ActiveChooN June 9, 2020 12:01
@bsekachev bsekachev requested a review from nmanovic as a code owner June 9, 2020 12:01
@bsekachev bsekachev changed the title Bs/some features Added shortcuts & ability to search a label Jun 9, 2020
@bsekachev bsekachev changed the title Added shortcuts & ability to search a label [React] Added shortcuts & ability to search a label Jun 9, 2020
@coveralls
Copy link

coveralls commented Jun 9, 2020

Pull Request Test Coverage Report for Build 5722

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 117 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 65.78%

Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/extractor.py 1 91.01%
datumaro/datumaro/components/launcher.py 5 81.4%
datumaro/datumaro/util/init.py 12 65.93%
datumaro/datumaro/plugins/voc_format/converter.py 29 89.26%
datumaro/datumaro/cli/contexts/model/init.py 32 17.78%
datumaro/datumaro/plugins/openvino_launcher.py 38 3.97%
Totals Coverage Status
Change from base Build 5592: -0.04%
Covered Lines: 10919
Relevant Lines: 16203

💛 - Coveralls

@ActiveChooN
Copy link
Contributor

@bsekachev, can you add tooltip with shortcut prompt to split mode button and change color area?

@bsekachev
Copy link
Member Author

@bsekachev, can you add tooltip with shortcut prompt to split mode button and change color area?

Sure.

Copy link
Contributor

nmanovic commented Jun 9, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 25
           

See the complete overview on Codacy

ActiveChooN
ActiveChooN previously approved these changes Jun 11, 2020
@bsekachev bsekachev merged commit 27e43da into develop Jun 15, 2020
@bsekachev bsekachev deleted the bs/some_features branch June 17, 2020 15:42
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
* Fixed remark-linter errors in CONTRIBUTING.md, added python3-tk to the installation guide

* Added labels search

* Added shortcuts to change color and split

* Updated version

* Updated CHANGELOG.md

* Added title

* Added shortcut hint for change color, added ability to change color of group/label using the shortcut

* Updated CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants