Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove information about the email from the basic user information #1627

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

nmanovic
Copy link
Contributor

@nmanovic nmanovic commented Jun 2, 2020

Motivation and context

Now CVAT by default can return information about users (/api/v1/users end point). It contains basic information about the user including the e-mail. Need to hide e-mail by default.

How has this been tested?

Tests for cvat server were modified to address the change.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic nmanovic changed the title [WIP] Remove information about the email from the basic user information Remove information about the email from the basic user information Jun 2, 2020
@nmanovic nmanovic requested a review from azhavoro June 2, 2020 13:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5406

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 65.657%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 2 77.06%
Totals Coverage Status
Change from base Build 5398: 0.03%
Covered Lines: 10836
Relevant Lines: 16101

💛 - Coveralls

@azhavoro azhavoro merged commit 79c39ad into develop Jun 2, 2020
@nmanovic nmanovic deleted the nm/remove_public_email branch June 2, 2020 18:24
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
…vat-ai#1627)

* Remove information about the email from the basic user information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants