Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git app paths #1400

Merged
merged 3 commits into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- VOC format exports Upper case labels correctly in lower case (https://github.com/opencv/cvat/pull/1379)
- Fixed polygon exporting bug in COCO dataset (https://github.com/opencv/cvat/issues/1387)
- Task creation from remote files (https://github.com/opencv/cvat/pull/1392)
- Git repos paths (https://github.com/opencv/cvat/pull/1400)

### Security
-
Expand Down
26 changes: 13 additions & 13 deletions cvat/apps/git/git.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (C) 2018 Intel Corporation
# Copyright (C) 2018-2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Expand Down Expand Up @@ -52,20 +52,20 @@ def _read_old_diffs(diff_dir, summary):


class Git:
def __init__(self, db_git, tid, user):
def __init__(self, db_git, db_task, user):
self._db_git = db_git
self._url = db_git.url
self._path = db_git.path
self._tid = tid
self._tid = db_task.id
self._user = {
"name": user.username,
"email": user.email or "[email protected]"
}
self._cwd = os.path.join(os.getcwd(), "data", str(tid), "repos")
self._diffs_dir = os.path.join(os.getcwd(), "data", str(tid), "repos_diffs_v2")
self._task_mode = Task.objects.get(pk = tid).mode
self._task_name = re.sub(r'[\\/*?:"<>|\s]', '_', Task.objects.get(pk = tid).name)[:100]
self._branch_name = 'cvat_{}_{}'.format(tid, self._task_name)
self._cwd = os.path.join(db_task.get_task_artifacts_dirname(), "repos")
self._diffs_dir = os.path.join(db_task.get_task_artifacts_dirname(), "repos_diffs_v2")
self._task_mode = db_task.mode
self._task_name = re.sub(r'[\\/*?:"<>|\s]', '_', db_task.name)[:100]
self._branch_name = 'cvat_{}_{}'.format(db_task.id, self._task_name)
self._annotation_file = os.path.join(self._cwd, self._path)
self._sync_date = db_git.sync_date
self._lfs = db_git.lfs
Expand Down Expand Up @@ -377,7 +377,7 @@ def initial_create(tid, git_path, lfs, user):
db_git.lfs = lfs

try:
_git = Git(db_git, tid, db_task.owner)
_git = Git(db_git, db_task, db_task.owner)
_git.init_repos()
db_git.save()
except git.exc.GitCommandError as ex:
Expand All @@ -393,7 +393,7 @@ def push(tid, user, scheme, host):
db_task = Task.objects.get(pk = tid)
db_git = GitData.objects.select_for_update().get(pk = db_task)
try:
_git = Git(db_git, tid, user)
_git = Git(db_git, db_task, user)
_git.init_repos()
_git.push(user, scheme, host, db_task, db_task.updated_date)

Expand Down Expand Up @@ -427,7 +427,7 @@ def get(tid, user):
response['status']['value'] = str(db_git.status)
else:
try:
_git = Git(db_git, tid, user)
_git = Git(db_git, db_task, user)
_git.init_repos(True)
db_git.status = _git.remote_status(db_task.updated_date)
response['status']['value'] = str(db_git.status)
Expand Down Expand Up @@ -459,8 +459,8 @@ def _onsave(jid, user, data, action):
db_task = Job.objects.select_related('segment__task').get(pk = jid).segment.task
try:
db_git = GitData.objects.select_for_update().get(pk = db_task.id)
diff_dir = os.path.join(os.getcwd(), "data", str(db_task.id), "repos_diffs")
diff_dir_v2 = os.path.join(os.getcwd(), "data", str(db_task.id), "repos_diffs_v2")
diff_dir = os.path.join(db_task.get_task_artifacts_dirname(), "repos_diffs")
diff_dir_v2 = os.path.join(db_task.get_task_artifacts_dirname(), "repos_diffs_v2")

summary = {
"update": 0,
Expand Down