Az/chunk size #1315
Merged
Az/chunk size #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Mar 25, 2020
| @@ -0,0 +1,18 @@ | |||
| # Generated by Django 2.2.10 on 2020-03-24 12:22 | |||
There was a problem hiding this comment.
Can we splash the migration?
nmanovic
reviewed
Mar 25, 2020
cvat/apps/engine/task.py
Outdated
| if isinstance(compressed_chunk_writer, ZipCompressedChunkWriter): | ||
| w, h = extractor.get_image_size() | ||
| area = h * w | ||
| if area <= 1920 * 1080: |
There was a problem hiding this comment.
Does it make sense to have for small resolutions bigger chunk? Something like max(1920 * 1080 * 18 // area * 2, 2)
There was a problem hiding this comment.
Maybe better to have clip(1920 * 1080 * 18 // area * 2, 2, 72)
nmanovic
reviewed
Mar 26, 2020
| @@ -252,25 +253,33 @@ def update_progress(progress): | |||
| compressed_chunk_writer = compressed_chunk_writer_class(db_data.image_quality) | |||
| original_chunk_writer = original_chunk_writer_class(100) | |||
|
|
|||
| # calculate chunk size if it isn't specified | |||
| if db_data.chunk_size is None: | |||
There was a problem hiding this comment.
@azhavoro , will it be critical for current video decoder if somebody specify a wrong chunk_size (too small or even)?
nmanovic
reviewed
Mar 26, 2020
| @@ -52,7 +52,27 @@ const webConfig = { | |||
| sourceType: 'unambiguous', | |||
| }, | |||
| }, | |||
| }], | |||
| }, { | |||
| test: /3rdparty\/.*\.worker\.js$/, | |||
There was a problem hiding this comment.
@azhavoro , why the change is necessary for the patch?
nmanovic
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.