added validators for start_frame, stop_frane and chunk_size #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Mar 24, 2020
cvat/apps/engine/serializers.py
Outdated
|
|
||
| # pylint: disable=no-self-use | ||
| def validate_start_frame(self, value): | ||
| if not value > 0: |
There was a problem hiding this comment.
My bad, it's PositiveIntegerField at the Data model that can be 0 and manual validation is not needed in this case.
nmanovic
reviewed
Mar 24, 2020
cvat/apps/engine/serializers.py
Outdated
|
|
||
| # pylint: disable=no-self-use | ||
| def validate_stop_frame(self, value): | ||
| if not value > 0: |
There was a problem hiding this comment.
What is the value for stop frame by default?
There was a problem hiding this comment.
The same as above, I've deleted this validation.
nmanovic
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.