Canvas failing and chunk loading status #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
previously approved these changes
Mar 24, 2020
ActiveChooN
changed the title
|
I found one issue in this patch (at least I cannot reproduce it in data streaming branch)
You can get an uncaught exception in console It reproduces not every time, but quite often. |
|
@azhavoro Can you look at this? I guess this error does not apply to my PR. |
ok |
|
@azhavoro |
azhavoro
reviewed
Mar 26, 2020
azhavoro
approved these changes
Mar 27, 2020
nmanovic
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.