Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose down command as written in the readme does not remove volumes #14

Closed
joaocaldeira opened this issue Jul 24, 2018 · 4 comments
Assignees
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release enhancement New feature or request

Comments

@joaocaldeira
Copy link

The option -v needs to be added. If that is not done, the data will still be there the next time docker-compose up is run.

@nmanovic
Copy link
Contributor

Hi @joaocaldeira ,

Could you please explain why it is bad? In general we don't delete volumes specially. Usually we "down" a container if it is necessary to update the tool or maintain its host. I would say in general case users want to have data on the next time docker-compose up is run. What is your use case?

@nmanovic nmanovic added the question Further information is requested label Jul 25, 2018
@joaocaldeira
Copy link
Author

More directly, my point was that listing docker-compose down is inconsistent with the sentence preceding it:

The command below will stop and remove containers, networks, volumes, and images created by up.

To answer your question: my use case here was that I added some videos to the tool for testing when I first installed it, and then wanted to clear all data and restart cvat before adding the videos I actually want annotated.

@nmanovic
Copy link
Contributor

I see. We will update README.md file. We got the line directly from documentation and it describes the command with all options. In our case we probably need to write "The command below will stop and remove containers and networks created by up". The sentence isn't precise (external network isn't removed) but I believe it is sufficient for the case. Will it work?

@nmanovic nmanovic added enhancement New feature or request and removed question Further information is requested labels Jul 25, 2018
@nmanovic nmanovic self-assigned this Jul 25, 2018
@joaocaldeira
Copy link
Author

Yes, that sounds good. Thanks!

@nmanovic nmanovic added the Easy to fix The issue is easy to fix and probably it will be release in a next minor release label Jul 29, 2018
TOsmanov pushed a commit to TOsmanov/cvat that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy to fix The issue is easy to fix and probably it will be release in a next minor release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants