Skip to content

Commit

Permalink
[Datumaro] Fix COCO keypoint export bug (#1388)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhiltsov-max authored Apr 12, 2020
1 parent 73346b3 commit bd65924
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Merge is allowed for points, but clicks on points conflict with frame dragging logic
- Removed objects are visible for search
- Add missed task_id and job_id fields into exception logs for the new UI (https://github.com/opencv/cvat/pull/1372)
- Fixed polygon exporting bug in COCO dataset (https://github.com/opencv/cvat/issues/1387)
- Task creation from remote files (https://github.com/opencv/cvat/pull/1392)

### Security
Expand Down
6 changes: 3 additions & 3 deletions datumaro/datumaro/plugins/coco_format/converter.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

# Copyright (C) 2019 Intel Corporation
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Expand Down Expand Up @@ -364,9 +364,9 @@ def find_solitary_points(cls, annotations):
solitary_points = []

for g_id, group in groupby(annotations, lambda a: a.group):
if g_id and not cls.find_instance_anns(group):
if not g_id or g_id and not cls.find_instance_anns(group):
group = [a for a in group if a.type == AnnotationType.points]
solitary_points.extend(group)
solitary_points.extend(group)

return solitary_points

Expand Down
3 changes: 3 additions & 0 deletions datumaro/tests/test_coco_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,9 @@ def __iter__(self):
annotations=[
# Solitary keypoints
Points([1, 2, 0, 2, 4, 1], label=5, id=3),

# Some other solitary annotations (bug #1387)
Polygon([0, 0, 4, 0, 4, 4], label=3, id=4),
]),

DatasetItem(id=3, subset='val',
Expand Down

0 comments on commit bd65924

Please sign in to comment.