-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak problem #15
Comments
This fix should take care of the problem! Copies of the qid and docno were not being freed properly.
|
Great, I quit this tool for this reason, thanks for fixing it. Just a thing on your PR, it's big, author might not accept it directly. May be consider having several smaller PR for each issue ? Since they are not related Thanks a lot for this work |
@Ricocotam I agree in spirit (and it was originally the plan to have multiple PRs), but there's a lot of interdependence between the changes made (e.g., 3 of the 4 rely on the addition of a python wrapper around the extension). @cvangysel will this hold up the PR, and would it help speed up the process if I split them up? I could, but it would be a pain. |
* support measure family nicknames #17 * Custom k for cut metrics #12 * support for alternative (nicer) formats for measure params #12. Built wrapper around cpp module which converts alternative formats to trec_eval format. * plugged memory leak #15 * removed type hints for python<3.5 * removed type hints for python<3.5 * Several fixes 1) Fixed issue with empty qrels on some platforms 2) Exposed the values nicknames expand to and moved logic to wrapper 3) Some cleanupq * bump version to 0.5 * bump version to 0.5
Hi,
Thanks for sharing the tool! It is indeed a very useful one!
I noticed a memory leak problem when running
evaluator.evaluate
. It allocates memory slightly higher than the size of the run file, but never releases the memory. To reproduce it, I attached a simple program, with sampleqrel
andrun
files.pytrec_eval_test.zip
Here is the results of memory profiling. As you can see
del res
does not release the memory, leading to allocation of large memory after several runs:Line # Mem usage Increment Line Contents
The problem made me go back to old style ac-hoc running of trec_eval. It would be great to get through it, and I am happy to help.
Best,
Navid
The text was updated successfully, but these errors were encountered: