Skip to content

Commit

Permalink
Fix warnings (mamba-org#2760)
Browse files Browse the repository at this point in the history
  • Loading branch information
Hind-M authored and cvanelteren committed Aug 29, 2023
1 parent f3b1ce8 commit efaa013
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion libmamba/src/core/transaction.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ namespace mamba
}
else
{
const Channel& chan = m_pool.channel_context().make_channel(std::string(str));
const Channel& chan = m_pool.channel_context().make_channel(str);
chan_name = chan.canonical_name();
}
}
Expand Down
2 changes: 1 addition & 1 deletion libmamba/tests/libmamba_lock/lock.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ main(int argc, char** argv)
{
CLI::App app{};
fs::u8path path;
int timeout = 1;
std::size_t timeout = 1;

CLI::App* lock_com = app.add_subcommand("lock", "Lock a path");
lock_com->add_option("path", path, "Path to lock");
Expand Down
10 changes: 5 additions & 5 deletions libmambapy/src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -554,15 +554,15 @@ PYBIND11_MODULE(bindings, m)
)
.def_property(
"use_lockfiles",
[](Context& ctx)
[](Context& context)
{
ctx.use_lockfiles = is_file_locking_allowed();
return ctx.use_lockfiles;
context.use_lockfiles = is_file_locking_allowed();
return context.use_lockfiles;
},
[](Context& ctx, bool allow)
[](Context& context, bool allow)
{
allow_file_locking(allow);
ctx.use_lockfiles = allow;
context.use_lockfiles = allow;
}
)
.def("set_verbosity", &Context::set_verbosity)
Expand Down
2 changes: 1 addition & 1 deletion micromamba/src/run.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ set_ps_command(CLI::App* subcom)
#endif
for (auto& p : procs)
{
PID pid = std::stoull(p["pid"].get<std::string>());
PID pid = std::stoi(p["pid"].get<std::string>());
stop_process(p["name"], pid);
}
if (procs.empty())
Expand Down

0 comments on commit efaa013

Please sign in to comment.