Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hearts 2024 announcement #1110

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

itsalaidbacklife
Copy link
Contributor

This updates the AnnouncementDialog to:

  1. Support optional startTime and endTime, hiding the announcement outside their bounds, unless specified
  2. Allows embedding links inside paragraphs

Issue number

N/A

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

@@ -1,8 +1,9 @@
<template>
<BaseDialog
v-if="announcementIsActive"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it works, but I'm not sure how to test it. The weird thing is that this component is so coupled to the announcementData.js file without using props. For that reason, I'm unsure how to set up a test to force the announcement data to have different values. Maybe the trick is to expose it to the window or as a store?

This might be a usecase for component testing, but I'm similarly unsure how to stub the annoucement data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant