Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Clean up and RELEASE the GameState API #965

Open
itsalaidbacklife opened this issue Jun 16, 2024 · 0 comments
Open

[Feature]: Clean up and RELEASE the GameState API #965

itsalaidbacklife opened this issue Jun 16, 2024 · 0 comments
Labels
backend Requires changes to the (node) backend webserver enhancement New feature or request frontend Requires changes to the frontend (vue) client version-major A large update that warrants changing the MAJOR version of the app e.g. (4.0.0 => 5.0.0)

Comments

@itsalaidbacklife
Copy link
Contributor

itsalaidbacklife commented Jun 16, 2024

Feature Summary

After all other issues in the GameState API MVP Project are completed, we should make the necessary changes to utilize the GameState API in production.

Detailed Description

Specifically, this will require:

  1. Removing the feature flags scripts from package.json for enabling/disabling the GameState API
  2. Reverting [Feature]: Update CI runs to test twice: with and without the USE_GAMESTATE_API feature flags #963 so that CI the tests only run once in CI (vs with + without the GameState API)
  3. Removing all references to the SAILS_USE_GAMESTATE_API, VITE_USE_GAMESTATE_API, and CYPRESS_USE_GAMESTATE_API from frontend and test code such that app code + tests all use the GameState API all the time
  4. Remove all the routes and controller files for the legacy api calls that are replaced by the GameState API endpoints
  5. Clean up the endpoint callers to remove extraneous data e.g. opId everywhere it's used.

Note: Look for comments with // FIXME: Remove in #965 throughout the codebase to clean these up. For example:
src/stores/game.js: remove opId and targetId from requestResolveSevenDoubleJacks

@itsalaidbacklife itsalaidbacklife added enhancement New feature or request version-major A large update that warrants changing the MAJOR version of the app e.g. (4.0.0 => 5.0.0) backend Requires changes to the (node) backend webserver frontend Requires changes to the frontend (vue) client labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires changes to the (node) backend webserver enhancement New feature or request frontend Requires changes to the frontend (vue) client version-major A large update that warrants changing the MAJOR version of the app e.g. (4.0.0 => 5.0.0)
Projects
Status: Todo
Development

No branches or pull requests

1 participant